-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade sdk with app version fix for state-sync #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
A:automerge
A:backport/v9.x
Do not use. backport patches to v9.x branch
labels
May 24, 2022
ValarDragon
reviewed
May 25, 2022
ValarDragon
reviewed
May 25, 2022
ValarDragon
approved these changes
May 25, 2022
mergify bot
pushed a commit
that referenced
this pull request
May 25, 2022
Closes: #XXX ## What is the purpose of the change Upgrade SDK with the app version change and set the app version in the upgrade handler ## Testing and Verifying - e2e test for state sync is in progress: #1572 - upgrade itself is verified by the existing e2e test - needs manual testing ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? yes - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes - How is the feature or change documented? not applicable (cherry picked from commit 1510160) # Conflicts: # app/upgrades/v9/upgrades.go
p0mvn
added a commit
that referenced
this pull request
May 25, 2022
… (#1574) * chore: upgrade sdk with app version fix for state-sync (#1570) Closes: #XXX ## What is the purpose of the change Upgrade SDK with the app version change and set the app version in the upgrade handler ## Testing and Verifying - e2e test for state sync is in progress: #1572 - upgrade itself is verified by the existing e2e test - needs manual testing ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? yes - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes - How is the feature or change documented? not applicable (cherry picked from commit 1510160) # Conflicts: # app/upgrades/v9/upgrades.go * resolve conflicts Co-authored-by: Roman <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Upgrade SDK with the app version change and set the app version in the upgrade handler
Testing and Verifying
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? yes